Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Couple fixes to improve error reporting #16895

Merged
merged 6 commits into from
Oct 1, 2024

Conversation

emrysal
Copy link
Contributor

@emrysal emrysal commented Oct 1, 2024

What does this PR do?

  • Prevent 4XX status codes from reporting to Sentry on the api/* endpoints.
  • Remove some unnecessary logs
  • Fix booking cancellation payload throwing a 500 error when the 'id' or 'uid' are both omitted.

@graphite-app graphite-app bot requested a review from a team October 1, 2024 10:45
@keithwillcode keithwillcode added core area: core, team members only foundation labels Oct 1, 2024
@dosubot dosubot bot added the api area: API, enterprise API, access token, OAuth label Oct 1, 2024
Copy link

vercel bot commented Oct 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 11:55am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Oct 1, 2024 11:55am

Copy link

graphite-app bot commented Oct 1, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (10/01/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (10/01/24)

1 label was added to this PR based on Keith Williams's automation.

keithwillcode
keithwillcode previously approved these changes Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

E2E results are ready!

@emrysal emrysal merged commit a95729f into main Oct 1, 2024
39 checks passed
@emrysal emrysal deleted the chore/except-user-errors-from-reporting-to-sentry branch October 1, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api area: API, enterprise API, access token, OAuth core area: core, team members only foundation ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants